Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiUsersSelectAction should have selected_users, not selected_user. #422

Closed
4 of 9 tasks
Iruyan-Zak opened this issue Mar 8, 2020 · 0 comments · Fixed by #423
Closed
4 of 9 tasks

MultiUsersSelectAction should have selected_users, not selected_user. #422

Iruyan-Zak opened this issue Mar 8, 2020 · 0 comments · Fixed by #423
Assignees
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented TypeScript-specific

Comments

@Iruyan-Zak
Copy link

Description

Describe your issue here.

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

Reproducible in:

package version:

node version:

OS version(s):

Steps to reproduce:

Receive action from multi-select menu with user list of Interactive Components.

(Jump this Block Kit Builder page and select users from the button in preview, then show payload:
https://api.slack.com/tools/block-kit-builder?mode=message&blocks=%5B%7B%22type%22%3A%22section%22%2C%22text%22%3A%7B%22type%22%3A%22mrkdwn%22%2C%22text%22%3A%22Pick%20one%20or%20more%20items%20from%20the%20list%22%7D%2C%22accessory%22%3A%7B%22action_id%22%3A%22text1234%22%2C%22type%22%3A%22multi_users_select%22%2C%22placeholder%22%3A%7B%22type%22%3A%22plain_text%22%2C%22text%22%3A%22Select%20users%22%7D%7D%7D%5D)

Expected result:

As well as other multi-select menu, the payload of action of multi-select menu with user list has plural form property name selected_users about selected items.

Actual result:

Current type definition of MultiUsersSelectAction has singular form property name selected_user.

Attachments:

Logs, screenshots, screencast, sample project, funny gif, etc.

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented TypeScript-specific labels Mar 8, 2020
@seratch seratch self-assigned this Mar 8, 2020
seratch added a commit to seratch/bolt-js that referenced this issue Mar 8, 2020
seratch added a commit to seratch/bolt-js that referenced this issue Mar 8, 2020
stevengill added a commit that referenced this issue Mar 9, 2020
Fix #422 invalid fields in MultiUsersSelectAction
seratch added a commit that referenced this issue Mar 10, 2020
[v2] Fix #422 invalid fields in MultiUsersSelectAction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented TypeScript-specific
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants