View type missing optional id from response

[tteltrab]

Description

In the docs, in re: updating views

To update a view, you can use the built-in client to call views.update with the view_id that was generated when you opened the view, and the updated blocks array. If you’re updating the view when a user interacts with an element inside of an existing view, the view_id will be available in the body of the request.

app.action('button_abc', ({ ack, body, context }) => {
  // Acknowledge the button request
  ack();
  try {
    const result = app.client.views.update({
      token: context.botToken,
      // Pass the view_id
      view_id: body.view.id,

Typescript bindings for View don't have an id property on the interface, which is causing errors. https://github.com/slackapi/node-slack-sdk/blob/master/packages/types/src/index.ts#L35

Not sure about this type, also not sure about opening the issue here, I understand the type is there ^ but it seems the intent of the View type is to be the view object sent with views.open API call, not to handle the ViewResponse which has an id.

What type of issue is this? (place an x in one of the [ ])

• bug
• enhancement (feature request)
• question
• documentation related
• testing related
• discussion

Bugfeature? It's an enhancement to the type bindings, but I can't reference a value that is definitely there in the response because of it when using typescript (have to give it the good old @ts-ignore).

Requirements (place an x in each of the [ ])

• I've read and understood the Contributing guidelines and have done my best effort to follow them.
• I've read and agree to the Code of Conduct.
• I've searched for any related issues and avoided creating a duplicate issue.

---

Bug Report

Reproducible in:

package version: 1.8.0

node version: 12.14.1

OS version(s): MacOS 10.15.1

Steps to reproduce:

1. See above description

Expected result:

Should be able to reference body.view.id

Actual result:

TypeError

Attachments:

[seratch]

@tteltrab Thank you for taking the time to flag this. I'll work on the fix.