Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorization examples are different from real results #495

Closed
4 of 9 tasks
Zrce opened this issue May 12, 2020 · 2 comments
Closed
4 of 9 tasks

Authorization examples are different from real results #495

Zrce opened this issue May 12, 2020 · 2 comments
Labels
docs M-T: Documentation work only

Comments

@Zrce
Copy link

Zrce commented May 12, 2020

Description

Describe your issue here.

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Steps to reproduce:

  1. Go to https://slack.dev/bolt-js/concepts#authorization
  2. Compare with result of app.client.oauth.v2.access
  3. Adapt to real result objects

Expected result:

What you expected to happen

Documentation to use a real result object and the naming of the real results. e.g.

botToken: team.access_token,
botId: team.app_id,
botUserId: team.bot_user_id

It's likely that you store the full result in a database. Then the team id would also be

if ((team.team.id 

Actual result:

botToken: team.botToken,
botId: team.botId,
botUserId: team.botUserId
if ((team.teamId
@seratch seratch added the docs M-T: Documentation work only label May 13, 2020
@seratch
Copy link
Member

seratch commented May 13, 2020

👋 In the document page you mentioned, the installations is a pseudo in-memory database storing OAuth results, not the direct reference to oauth.v2.access results.

If you're looking for more realistic examples or information, check the implementation in pull request #479. The PR is going to introduce the built-in implementation of the authorization logics to Bolt for JS.

@seratch
Copy link
Member

seratch commented Jun 9, 2020

@Zrce Hello, are you still looking for more information here? If my previous comment is helpful or you're no longer working on this, could you close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

No branches or pull requests

3 participants