Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added oauth package to bolt #479

Merged
merged 7 commits into from
May 22, 2020
Merged

added oauth package to bolt #479

merged 7 commits into from
May 22, 2020

Conversation

stevengill
Copy link
Member

@stevengill stevengill commented Apr 20, 2020

Summary

Issue: #478

Requirements (place an x in each [ ])

src/App.ts Show resolved Hide resolved
src/App.ts Outdated Show resolved Hide resolved
src/App.ts Show resolved Hide resolved
src/ExpressReceiver.ts Outdated Show resolved Hide resolved
src/ExpressReceiver.ts Outdated Show resolved Hide resolved
src/ExpressReceiver.ts Outdated Show resolved Hide resolved
src/ExpressReceiver.ts Outdated Show resolved Hide resolved
src/ExpressReceiver.ts Outdated Show resolved Hide resolved
src/ExpressReceiver.ts Outdated Show resolved Hide resolved
src/App.ts Show resolved Hide resolved
@seratch seratch added enhancement M-T: A feature request for new functionality semver:minor labels Apr 24, 2020
@stevengill stevengill force-pushed the oauth branch 2 times, most recently from b39a6a3 to f93c948 Compare April 30, 2020 04:31
@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@a86a30a). Click here to learn what that means.
The diff coverage is 71.69%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #479   +/-   ##
=========================================
  Coverage          ?   82.99%           
=========================================
  Files             ?        7           
  Lines             ?      594           
  Branches          ?      186           
=========================================
  Hits              ?      493           
  Misses            ?       68           
  Partials          ?       33           
Impacted Files Coverage Δ
src/ExpressReceiver.ts 65.21% <67.85%> (ø)
src/App.ts 87.44% <75.00%> (ø)
src/helpers.ts 90.90% <100.00%> (ø)
src/middleware/process.ts 100.00% <0.00%> (ø)
src/errors.ts 100.00% <0.00%> (ø)
src/middleware/builtin.ts 82.78% <0.00%> (ø)
src/conversation-store.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a86a30a...47428bf. Read the comment docs.

docs/_basic/authenticating_oauth.md Outdated Show resolved Hide resolved
docs/_basic/authenticating_oauth.md Outdated Show resolved Hide resolved
docs/_basic/authenticating_oauth.md Outdated Show resolved Hide resolved
docs/_basic/authenticating_oauth.md Outdated Show resolved Hide resolved
docs/_basic/authenticating_oauth.md Outdated Show resolved Hide resolved
docs/_basic/authenticating_oauth.md Outdated Show resolved Hide resolved
docs/_basic/authenticating_oauth.md Outdated Show resolved Hide resolved
docs/_basic/authenticating_oauth.md Show resolved Hide resolved
src/App.ts Outdated Show resolved Hide resolved
@stevengill
Copy link
Member Author

Thanks for reviewing this with me today @aoberoi! Merging it in

@stevengill stevengill merged commit b65c74f into slackapi:master May 22, 2020
@stevengill stevengill deleted the oauth branch May 22, 2020 04:16
@junjizhi junjizhi mentioned this pull request Jun 24, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality semver:minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants