Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clientOptions.logger option #496

Closed
3 tasks done
aoberoi opened this issue May 13, 2020 · 1 comment · Fixed by #856
Closed
3 tasks done

Add clientOptions.logger option #496

aoberoi opened this issue May 13, 2020 · 1 comment · Fixed by #856
Labels
enhancement M-T: A feature request for new functionality good first issue Good for newcomers
Milestone

Comments

@aoberoi
Copy link
Contributor

aoberoi commented May 13, 2020

Description

We'd like to support the use case of customizing the logger for the WebClient instances that the Bolt App creates. Some of the motivation and ideas around this change were discussed and agreed upon here: #278 (comment)

Side note: in the end we'd like to accomplish the following

  • logLevel affects the App instance but also cascades to all owned objects with loggers.
  • to customize the Receiver’s logger, you’re expected to set the receiver option to a fully initialized receiver with your custom logger already set.
  • to customize the WebClient’s logger, you’re expected to set the clientOptions.logger option (that's what this issue is about).
  • to customize the App’s logger, use the logger option.

We should probably have tests that verify all the cases above ☝️

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@aoberoi aoberoi added the enhancement M-T: A feature request for new functionality label May 13, 2020
@seratch seratch added this to the 3.4.0 milestone Mar 23, 2021
@seratch seratch added the good first issue Good for newcomers label Mar 23, 2021
seratch added a commit to seratch/bolt-js that referenced this issue Mar 24, 2021
seratch added a commit that referenced this issue Mar 25, 2021
…ttributes too) (#856)

* Fix #496 Add clientOptions.logger option

* Update codecov settings

* Add warn logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants