Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to use a custom express app and/or router to ExpressReceiver #868

Closed
4 of 10 tasks
rr-codes opened this issue Apr 7, 2021 · 2 comments · Fixed by #1084
Closed
4 of 10 tasks

Add ability to use a custom express app and/or router to ExpressReceiver #868

rr-codes opened this issue Apr 7, 2021 · 2 comments · Fixed by #1084
Assignees
@seratch
Labels
enhancement M-T: A feature request for new functionality
Milestone
3.7.0

Comments

@rr-codes
Copy link
Contributor

rr-codes commented Apr 7, 2021

Description

I would like to have control to create my own express app and router and pass them into the ExpressReceiver, instead of having the receiver itself create them. Making this change would require very little code added.

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • example code related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@gitwave gitwave bot added the untriaged label Apr 7, 2021
@stevengill
Copy link
Member

Hey @rr-codes,

I don't see any issue with this. Want to send a PR?

@stevengill stevengill added enhancement M-T: A feature request for new functionality and removed untriaged labels Apr 8, 2021
@rr-codes
Copy link
Contributor Author

rr-codes commented Apr 8, 2021

Hey @rr-codes,

I don't see any issue with this. Want to send a PR?

Yup!! Will do so tomorrow!

@rr-codes rr-codes mentioned this issue Apr 8, 2021
Closed
2 tasks
@seratch seratch added this to the 3.4.0 milestone Apr 8, 2021
@seratch seratch modified the milestones: 3.4.0, 3.5.0 Apr 21, 2021
@seratch seratch modified the milestones: 3.5.0, 3.6.0 Jul 14, 2021
@srajiang srajiang modified the milestones: 3.6.0, 3.7.0 Aug 19, 2021
seratch added a commit to seratch/bolt-js that referenced this issue Aug 25, 2021
@seratch
Fix slackapi#868 Add ability to use a custom express app and/or route…
8975e85 
…r to ExpressReceiver
@seratch seratch mentioned this issue Aug 25, 2021
Merged
2 tasks
seratch added a commit that referenced this issue Aug 25, 2021
@seratch
Fix #868 Add ability to use a custom express app and/or router to Exp…
99df66a 
…ressReceiver (#1084)
@seratch seratch self-assigned this Aug 26, 2021
@recurrence recurrence mentioned this issue Sep 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seratch seratch

Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Milestone
3.7.0
4 participants
@seratch @stevengill @rr-codes @srajiang