TypeScript error when using builtin onlyViewActions middleware

[rafaelgallani]

Description

When calling onlyViewActions method like this:

app.use(async (args) => {
    onlyViewActions(args);
});

I receive the following error:

Type 'SlackViewMiddlewareArgs<SlackViewAction> & AllMiddlewareArgs' is missing the following properties from type 'SlackShortcutMiddlewareArgs<SlackShortcut>': shortcut, say, respond

Here's the full error log:

  Type 'SlackViewMiddlewareArgs<SlackViewAction> & AllMiddlewareArgs' is not assignable to type '(AnyMiddlewareArgs & { view?: ViewSubmitAction | ViewClosedAction | undefined; }) & AllMiddlewareArgs'.
    Type 'SlackViewMiddlewareArgs<SlackViewAction> & AllMiddlewareArgs' is not assignable to type 'SlackShortcutMiddlewareArgs<SlackShortcut> & { view?: ViewSubmitAction | ViewClosedAction | undefined; } & AllMiddlewareArgs'.
      Type 'SlackViewMiddlewareArgs<SlackViewAction> & AllMiddlewareArgs' is missing the following properties from type 'SlackShortcutMiddlewareArgs<SlackShortcut>': shortcut, say, respond

But this wouldn't make sense, since args could be within these unions.
Also, the following snippet works perfectly - which indicates that could indeed be something wrong with the builtin middleware:

app.use(async (args) => {
    onlyCommands(args);
});

Are these middlewares internal? Should I be using them on production code or not?
Please let me know if I'm doing something wrong, but from what I could tell, I think that's pretty much how these builtin middlewares should be used:

• Pass a value of type AnyMiddlewareArgs & AllMiddlewareArgs to them
• They will check whether the type matches the requested assertion (e.g onlyActions definition below):
  

  bolt-js/src/middleware/builtin.ts

  Lines 36 to 45 in 9867e38

  	export const onlyActions: Middleware<AnyMiddlewareArgs & { action?: SlackAction }> = async ({ action, next }) => {
  	// Filter out any non-actions
  	if (action === undefined) {
  	return;
  	}
  	// It matches so we should continue down this middleware listener chain
  	// TODO: remove the non-null assertion operator
  	await next!();
  	};

• Continue down the middleware chain if the type matches.

What type of issue is this? (place an x in one of the [ ])

• bug
• enhancement (feature request)
• question
• documentation related
• example code related
• testing related
• discussion

Requirements (place an x in each of the [ ])

• I've read and understood the Contributing guidelines and have done my best effort to follow them.
• I've read and agree to the Code of Conduct.
• I've searched for any related issues and avoided creating a duplicate issue.

---

Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

Reproducible in:

package version: 3.3.0

node version: 15.8.0

OS version(s): Linux 5.11.16-arch1-1

Steps to reproduce:

1. Import onlyActions middleware;
2. Pass args as argument, where args is of type AnyMiddlewareArgs & AllMiddlewareArgs;
3. Check that the error is shown on TypeScript;

Expected result:

The middleware should work and check the types properly.

Actual result:

A Typescript error was displayed.

[seratch]

Hi @rafaelgalani, thanks for taking the time to report this issue! I've looked into this and found that this is an obvious bug. I've submitted PR #912 fixing this.