Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file_share message subtype is missing in the message property of SlackEventMiddlewareArgs<'message'> #926

Closed
4 of 10 tasks
rr-codes opened this issue May 18, 2021 · 1 comment · Fixed by #928
Closed
4 of 10 tasks
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:minor TypeScript-specific
Milestone

Comments

@rr-codes
Copy link
Contributor

Description

When checking the value of subtype of a message even't message, the type is "bot_message" | "ekm_access_denied" | "me_message" | "message_changed" | "message_deleted" | "message_replied" | "thread_broadcast" even though it may also be file_share. When trying to compare the values of subtype and file_share, it gives a TS error since it is not part of the type union even though it is a valid subtype.

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • example code related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

Reproducible in:

package version: 3.3.0

node version:

OS version(s):

Steps to reproduce:

Expected result:

What you expected to happen

Actual result:

What actually happened

Attachments:

Logs, screenshots, screencast, sample project, funny gif, etc.

@gitwave gitwave bot added the untriaged label May 18, 2021
@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:minor TypeScript-specific and removed untriaged labels May 18, 2021
@seratch seratch added this to the 3.4.0 milestone May 18, 2021
@seratch
Copy link
Member

seratch commented May 18, 2021

Hey @rr-codes, thanks for flagging this and you're right! I will look into this and fix it in the next minor version.

seratch added a commit to seratch/bolt-js that referenced this issue May 19, 2021
seratch added a commit to seratch/bolt-js that referenced this issue May 19, 2021
seratch added a commit that referenced this issue May 20, 2021
* Fix #926 by adding more subtype ones to message event types
* Add export to new types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:minor TypeScript-specific
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants