Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs to include the InstallationStore deleteInstallation method #1002

Merged
merged 4 commits into from
Jul 15, 2021
Merged

Update docs to include the InstallationStore deleteInstallation method #1002

merged 4 commits into from
Jul 15, 2021

Conversation

misscoded
Copy link
Contributor

Summary

Fixes #970

Update docs to include examples + references to recently added deleteInstallation method.

Relies on work included in oauth@2.2.

Requirements (place an x in each [ ])

@misscoded misscoded added the docs M-T: Documentation work only label Jul 14, 2021
@misscoded misscoded added this to the 3.5.0 milestone Jul 14, 2021
@codecov
Copy link

codecov bot commented Jul 14, 2021 •
edited
Loading

Codecov Report

Merging #1002 (68e0762) into main (260acde) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1002   +/-   ##
=======================================
  Coverage   66.41%   66.41%           
=======================================
  Files          13       13           
  Lines        1212     1212           
  Branches      357      357           
=======================================
  Hits          805      805           
  Misses        338      338           
  Partials       69       69

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 260acde...68e0762. Read the comment docs.

@misscoded misscoded requested a review from seratch July 14, 2021 06:09
seratch
seratch approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Once the JA version is also updated, we can merge this 👍

docs/_basic/ja_authenticating_oauth.md Outdated Show resolved Hide resolved
docs/_basic/ja_authenticating_oauth.md Outdated Show resolved Hide resolved
docs/_basic/ja_authenticating_oauth.md Outdated Show resolved Hide resolved
docs/_tutorials/reference.md Show resolved Hide resolved
@seratch
Copy link
Member

seratch commented Jul 15, 2021

Looks great to me 👍 Let me merge this now.

@seratch seratch merged commit 28f852e into slackapi:main Jul 15, 2021
@seratch
Copy link
Member

seratch commented Jul 15, 2021

Ah, sorry. This was a bit early. I will revert this.

seratch added a commit that referenced this pull request Jul 15, 2021
@seratch
Revert "Update docs to include the InstallationStore deleteInstallati…
711a511 
…on method (#1002)"

This reverts commit 28f852e.
@seratch seratch mentioned this pull request Jul 15, 2021
Merged
seratch added a commit that referenced this pull request Jul 15, 2021
@seratch
Revert "Update docs to include the InstallationStore deleteInstallati…
134618d 
…on method (#1002)" (#1004)

This reverts commit 28f852e.
seratch added a commit that referenced this pull request Jul 15, 2021
@seratch
Revert "Revert "Update docs to include the InstallationStore deleteIn…
399db34 
…stallation method (#1002)" (#1004)"

This reverts commit 134618d.
@seratch seratch mentioned this pull request Jul 15, 2021
Merged
seratch added a commit that referenced this pull request Jul 15, 2021
@seratch
Revert "Revert "Update docs to include the InstallationStore deleteIn…
b0343da 
…stallation method (#1002)" (#1004)" (#1005)

This reverts commit 134618d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seratch seratch seratch approved these changes

Assignees
No one assigned
Labels
docs M-T: Documentation work only
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.

Update docs to include deleteInstallation
2 participants
@misscoded @seratch