Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export MemoryInstallationStore and FileInstallationStore #1003

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

misscoded
Copy link
Contributor

Summary

Fixes #941

Exports the MemoryInstallationStore and FileInstallationStore classes from @slack/oauth to allow developers the ability to import and use them directly in their projects as the chosen InstallationStore.

Dependent on oauth@2.2

Requirements (place an x in each [ ])

@misscoded misscoded added the enhancement M-T: A feature request for new functionality label Jul 15, 2021
@misscoded misscoded added this to the 3.5.0 milestone Jul 15, 2021
@misscoded misscoded requested review from seratch and stevengill July 15, 2021 00:46
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the failing builds indicate, you need to release a new version of @slack/oauth that provides the store implementations first.

@misscoded
Copy link
Contributor Author

As the failing builds indicate, you need to release a new version of @slack/oauth that provides the store implementations first.

Yep! I've noted that dependency in the Summary. I'm trying to get everything in order and ready to go.

@seratch seratch marked this pull request as draft July 15, 2021 01:46
@misscoded misscoded marked this pull request as ready for review July 15, 2021 21:31
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #1003 (7265995) into main (260acde) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1003   +/-   ##
=======================================
  Coverage   66.41%   66.41%           
=======================================
  Files          13       13           
  Lines        1212     1212           
  Branches      357      357           
=======================================
  Hits          805      805           
  Misses        338      338           
  Partials       69       69           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 260acde...7265995. Read the comment docs.

@misscoded misscoded merged commit cbbb28d into slackapi:main Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Support for FileInstallationStore
3 participants