updated deleteInstallation example and fix #939 #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1021 +/- ##
=======================================
Coverage 68.89% 68.89%
=======================================
Files 13 13
Lines 1212 1212
Branches 357 357
=======================================
Hits 835 835
Misses 304 304
Partials 73 73 Continue to review full report at Codecov.
|
filmaj
approved these changes
Jul 27, 2021
docs/_basic/authenticating_oauth.md
Outdated
| @@ -12,6 +12,8 @@ Bolt for JavaScript will create a **Redirect URL** `slack/oauth_redirect`, which | |||
|
|
|||
| Bolt for JavaScript will also create a `slack/install` route, where you can find an `Add to Slack` button for your app to perform direct installs of your app. If you need any additional authorizations (user tokens) from users inside a team when your app is already installed or a reason to dynamically generate an install URL, manually instantiate an `ExpressReceiver`, assign the instance to a variable named `receiver`, and then call `receiver.installer.generateInstallUrl()`. Read more about `generateInstallUrl()` in the [OAuth docs](https://slack.dev/node-slack-sdk/oauth#generating-an-installation-url). | |||
|
|
|||
| **NOTE: The `Add to Slack` button on your apps App config page will not work with our Bolt's OAuth support. It does not include a state value. You must use the `slack/install` route created by your Bolt application to install the app.** | |||
There was a problem hiding this comment.
Suggested change
| **NOTE: The `Add to Slack` button on your apps App config page will not work with our Bolt's OAuth support. It does not include a state value. You must use the `slack/install` route created by your Bolt application to install the app.** | |
| **NOTE: The `Add to Slack` button on your app's App config page will not work with Bolt's OAuth support. It does not include a state value. You must use the `slack/install` route created by your Bolt application to install the app.** |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #939 and updates the
deleteInstallationexample to be consistent withstoreInstallation,fetchInstallationRequirements (place an
xin each[ ])