Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Japanese docs to apply #990 changes #1048

Merged
merged 6 commits into from
Aug 10, 2021
Merged

Update Japanese docs to apply #990 changes #1048

merged 6 commits into from
Aug 10, 2021
+359 −51

Conversation

hariNEzuMI928
Copy link
Contributor

@hariNEzuMI928 hariNEzuMI928 commented Aug 9, 2021 •
edited
Loading

Summary

Thanks for the great products🎉🎊👏
I made this PR to help you in any way I can.
I don't have a lot of experience with contributions. I apologize if I am wrong in my methods.

Requirements (place an x in each [ ])

@gitwave gitwave bot added the untriaged label Aug 9, 2021
seratch
seratch requested changes Aug 9, 2021
View reviewed changes
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR! Can you check my comments?

docs/_tutorials/getting_started_http.md Show resolved Hide resolved
docs/_tutorials/ja_getting_started.md Outdated Show resolved Hide resolved
docs/_tutorials/ja_getting_started_http.md Outdated Show resolved Hide resolved
docs/_tutorials/ja_getting_started_http.md Outdated Show resolved Hide resolved
@seratch seratch added docs M-T: Documentation work only and removed untriaged labels Aug 9, 2021
@seratch seratch added this to the 3.6.0 milestone Aug 9, 2021
hariNEzuMI928 and others added 3 commits August 10, 2021 20:30
@hariNEzuMI928 @seratch
Update docs/_tutorials/ja_getting_started.md
9f8afa5 
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
@hariNEzuMI928 @seratch
Update docs/_tutorials/ja_getting_started_http.md
5bf8406 
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
@hariNEzuMI928 @seratch
Update docs/_tutorials/ja_getting_started_http.md
15149e0 
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
@hariNEzuMI928
Copy link
Contributor Author

@seratch
Thanks for checking PR!
I resolved some suggestion.

@codecov
Copy link

codecov bot commented Aug 10, 2021 •
edited
Loading

Codecov Report

Merging #1048 (15149e0) into main (f712a3b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1048   +/-   ##
=======================================
  Coverage   68.89%   68.89%           
=======================================
  Files          13       13           
  Lines        1212     1212           
  Branches      357      357           
=======================================
  Hits          835      835           
  Misses        304      304           
  Partials       73       73

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f712a3b...15149e0. Read the comment docs.

@seratch seratch merged commit 4fff0f7 into slackapi:main Aug 10, 2021
@seratch seratch mentioned this pull request Aug 10, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seratch seratch seratch approved these changes

Assignees
No one assigned
Labels
docs M-T: Documentation work only
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hariNEzuMI928 @seratch