Update the documents to use respond over say in response to slash commands #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mands Slash commands can be invoked anywhere. In some situations like DM, say() function does not work as the bot user is not in the conversation. respond() can work in any situations.
seratch
requested review from
mwbrooks,
filmaj,
stevengill,
misscoded and
srajiang
seratch
commented
Aug 11, 2021
| @@ -25,7 +25,7 @@ async function addTimezoneContext({ payload, client, context, next }) { | |||
| await next(); | |||
| } | |||
|
|
|||
| app.command('request', addTimezoneContext, async ({ command, ack, client, context }) => { | |||
| app.command('/request', addTimezoneContext, async ({ command, ack, client, context }) => { | |||
Codecov Report
@@ Coverage Diff @@
## main #1059 +/- ##
=======================================
Coverage 68.89% 68.89%
=======================================
Files 13 13
Lines 1212 1212
Branches 357 357
=======================================
Hits 835 835
Misses 304 304
Partials 73 73 Continue to review full report at Codecov.
|
8 tasks
filmaj
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request updates some code snippets of slash command listeners to use
respond()oversay()method. The reason is t make the examples more robust. A slash command can be invoked anywhere. If the conversation where a user hit the command is the person's direct message,say()method does not work at all. Butrespond()works even for the use case.see also: #365 (comment)
Requirements (place an
xin each[ ])