Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated incorrect apphome test #1071

Merged
merged 1 commit into from
Aug 19, 2021
Merged

updated incorrect apphome test #1071

merged 1 commit into from
Aug 19, 2021

Conversation

stevengill
Copy link
Member

Summary

With the change that landed in @slack/types@2.2.0, this test is now incorrect as these two properties do not exist on the HomeView.

Requirements (place an x in each [ ])

@stevengill stevengill added the tests M-T: Testing work only label Aug 19, 2021
@stevengill stevengill added this to the 3.7.0 milestone Aug 19, 2021
@stevengill stevengill requested a review from srajiang August 19, 2021 19:29
@stevengill stevengill self-assigned this Aug 19, 2021
Copy link
Member

@srajiang srajiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, for reference, per https://api.slack.com/reference/surfaces/views, clear_on_close and notify_on_close are only available on the Modal, not on the Home.

@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #1071 (a0609fd) into main (1b1231a) will not change coverage.
The diff coverage is n/a.

❗ Current head a0609fd differs from pull request most recent head f0f448a. Consider uploading reports for the commit f0f448a to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1071   +/-   ##
=======================================
  Coverage   68.89%   68.89%           
=======================================
  Files          13       13           
  Lines        1212     1212           
  Branches      357      357           
=======================================
  Hits          835      835           
  Misses        304      304           
  Partials       73       73           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e050bb...f0f448a. Read the comment docs.

@stevengill stevengill merged commit 0ad0e89 into slackapi:main Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests M-T: Testing work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants