Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #982 Enable developers to customize the "/slack/install" webpage content #1083

Merged
merged 1 commit into from
Aug 28, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented Aug 25, 2021

Summary

This pull request fixes #982. Refer to the issue for details.

Requirements (place an x in each [ ])

@seratch seratch added the enhancement M-T: A feature request for new functionality label Aug 25, 2021
@seratch seratch added this to the 3.7.0 milestone Aug 25, 2021
@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #1083 (453d3f8) into main (926b669) will decrease coverage by 0.05%.
The diff coverage is 73.33%.

❗ Current head 453d3f8 differs from pull request most recent head ac6b5bb. Consider uploading reports for the commit ac6b5bb to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1083      +/-   ##
==========================================
- Coverage   71.01%   70.95%   -0.06%     
==========================================
  Files          13       13              
  Lines        1235     1243       +8     
  Branches      362      365       +3     
==========================================
+ Hits          877      882       +5     
- Misses        288      291       +3     
  Partials       70       70              
Impacted Files Coverage Δ
src/receivers/ExpressReceiver.ts 64.88% <25.00%> (-0.79%) ⬇️
src/receivers/render-html-for-install-path.ts 75.00% <66.66%> (-25.00%) ⬇️
src/receivers/HTTPReceiver.ts 32.77% <100.00%> (+0.75%) ⬆️
src/receivers/SocketModeReceiver.ts 69.49% <100.00%> (+1.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 926b669...ac6b5bb. Read the comment docs.

@seratch seratch force-pushed the issue-982-install-page-renderer branch from 4bbbd19 to b5938e6 Compare August 25, 2021 22:53
@seratch seratch marked this pull request as ready for review August 25, 2021 22:54
@seratch seratch self-assigned this Aug 26, 2021
@seratch
Copy link
Member Author

seratch commented Aug 27, 2021

This one is ready for merge but let's hold off merging until we merge #1024

@seratch seratch force-pushed the issue-982-install-page-renderer branch from a59e189 to ac6b5bb Compare August 28, 2021 00:23
@seratch
Copy link
Member Author

seratch commented Aug 28, 2021

Resolved conflicts ✅

@seratch seratch merged commit 2f463ce into slackapi:main Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable developers to customize the "/slack/install" webpage content
3 participants