Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more information to unhandled incoming request logging #1143

Merged
merged 3 commits into from
Oct 8, 2021

Conversation

misscoded
Copy link
Contributor

Summary

Partially addresses #1138.

This PR adds more information about incoming unhandled requests, specifically the method and endpoint (similar to the information offered when errors are thrown). This should save developers time when debugging cases where there's a mismatch in endpoints compared to the Request URLs in the app configuration.

Previous: [INFO] An unhandled request was ignored
With change: [INFO] Unhandled HTTP request (POST) made to /slack/bad-endpoint

Requirements (place an x in each [ ])

@misscoded misscoded added the enhancement M-T: A feature request for new functionality label Oct 4, 2021
@misscoded misscoded added this to the 3.8.0 milestone Oct 4, 2021
@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #1143 (c06e138) into main (01ad01a) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1143   +/-   ##
=======================================
  Coverage   71.71%   71.71%           
=======================================
  Files          15       15           
  Lines        1354     1354           
  Branches      402      402           
=======================================
  Hits          971      971           
  Misses        312      312           
  Partials       71       71           
Impacted Files Coverage Δ
src/receivers/HTTPReceiver.ts 37.12% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01ad01a...c06e138. Read the comment docs.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement as the first step!

To make the logging by the server consistent, we may want to add the method/path information to the error logging in L242 too.

@misscoded misscoded force-pushed the improve-unhandled-req-info branch from 1a9b811 to c06e138 Compare October 8, 2021 21:10
@misscoded misscoded merged commit b045c77 into slackapi:main Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants