Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify /slack/events path requirement. #1153

Merged
merged 3 commits into from
Oct 13, 2021
Merged

Clarify /slack/events path requirement. #1153

merged 3 commits into from
Oct 13, 2021

Conversation

mars
Copy link
Contributor

@mars mars commented Oct 11, 2021

Summary

I was stumped by the unhandled request was ignored errors from a new Bolt app.

Eventually found an existing issue here, and commented with the solution.

This PR is my attempt to help other folks avoid this frustration with unclear Request URL requirements.

Requirements (place an x in each [ ])

@CLAassistant
Copy link

CLAassistant commented Oct 11, 2021

CLA assistant check
All committers have signed the CLA.

@seratch seratch added the docs M-T: Documentation work only label Oct 13, 2021
@seratch seratch added this to the 3.8.0 milestone Oct 13, 2021
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to make this pull request! I left one comment on the change. Could you check it out if you have a chance?

README.md Outdated Show resolved Hide resolved
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
@mars
Copy link
Contributor Author

mars commented Oct 13, 2021

Thanks @seratch! Done ✅

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #1153 (7ee7003) into main (7f1ec57) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1153   +/-   ##
=======================================
  Coverage   71.71%   71.71%           
=======================================
  Files          15       15           
  Lines        1354     1354           
  Branches      402      402           
=======================================
  Hits          971      971           
  Misses        312      312           
  Partials       71       71           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f1ec57...7ee7003. Read the comment docs.

@seratch seratch merged commit a55ec4c into slackapi:main Oct 13, 2021
@seratch seratch self-assigned this Oct 13, 2021
srajiang pushed a commit to srajiang/bolt-js that referenced this pull request Oct 14, 2021
* Clarify `/slack/events` path requirement.
* We may change the log message in the future; generalize the statement

Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
srajiang pushed a commit to srajiang/bolt-js that referenced this pull request Oct 20, 2021
* Clarify `/slack/events` path requirement.
* We may change the log message in the future; generalize the statement

Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants