Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update slugs #1161

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Update slugs #1161

merged 1 commit into from
Oct 18, 2021

Conversation

srajiang
Copy link
Member

@srajiang srajiang commented Oct 14, 2021

Summary

Soon we will introduce validation on front-matter content, specifically slugs before they can be published to Contentful.
We will accept slugs formatted with hyphens (-) only, no underscores(_) or other special characters.

This change fixes one such example in this repo

@wongjas Added you as a reviewer as an FYI!

Requirements (place an x in each [ ])

@srajiang srajiang requested a review from wongjas October 14, 2021 18:44
@srajiang srajiang self-assigned this Oct 14, 2021
@srajiang srajiang added the docs M-T: Documentation work only label Oct 14, 2021
@srajiang srajiang added this to the 3.8.0 milestone Oct 14, 2021
@srajiang srajiang requested review from seratch and misscoded October 14, 2021 18:45
@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #1161 (b3adf35) into main (b696c72) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1161   +/-   ##
=======================================
  Coverage   71.71%   71.71%           
=======================================
  Files          15       15           
  Lines        1354     1354           
  Branches      402      402           
=======================================
  Hits          971      971           
  Misses        312      312           
  Partials       71       71           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b696c72...b3adf35. Read the comment docs.

@seratch seratch merged commit 7eedf9e into slackapi:main Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants