Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Japanese: Add deployment changes for AWS. Fixes #1067 #1165

Merged
merged 4 commits into from
Oct 18, 2021
Merged

Japanese: Add deployment changes for AWS. Fixes #1067 #1165

merged 4 commits into from
Oct 18, 2021

Conversation

wongjas
Copy link
Member

@wongjas wongjas commented Oct 18, 2021

Summary

Fixes #1067, adding deployment changes for AWS.

Requirements (place an x in each [ ])

@wongjas wongjas requested a review from seratch October 18, 2021 04:30
@codecov
Copy link

codecov bot commented Oct 18, 2021 •
edited
Loading

Codecov Report

Merging #1165 (54a2be5) into main (a55ec4c) will not change coverage.
The diff coverage is n/a.

❗ Current head 54a2be5 differs from pull request most recent head a817fdb. Consider uploading reports for the commit a817fdb to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1165   +/-   ##
=======================================
  Coverage   71.71%   71.71%           
=======================================
  Files          15       15           
  Lines        1354     1354           
  Branches      402      402           
=======================================
  Hits          971      971           
  Misses        312      312           
  Partials       71       71

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a55ec4c...a817fdb. Read the comment docs.

seratch
seratch requested changes Oct 18, 2021
View reviewed changes
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Can you check a few comments?

docs/_deployments/ja_aws-lambda.md Outdated
@@ -108,17 +108,28 @@ Bolt アプリを用意できました。次に AWS Lambda と Serverless Framew

**1. アプリを AWS Lambda に対応させる**

デフォルトでは、Bolt アプリがリッスンするのは HTTP リクエストです。このセクションでは Bolt アプリの[`レシーバー`](https://slack.dev/bolt-js/concepts#receiver)に手を加えて、Lambda 関数のイベントをリッスンするように変更します。
デフォルトでは、入門ガイドの Bolt サンプルアプリはソケットモードを使用しています。WebSocketイベントの代わりにHTTPリクエストをリッスンするため、 `app.js` の設定を変更しましょう。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, can you always have white spaces before/after alphabet words?

Suggested change
デフォルトでは、入門ガイドの Bolt サンプルアプリはソケットモードを使用しています。WebSocketイベントの代わりにHTTPリクエストをリッスンするため、 `app.js` の設定を変更しましょう。
デフォルトでは、入門ガイドの Bolt サンプルアプリはソケットモードを使用しています。WebSocket イベントの代わりに HTTP リクエストをリッスンするため、 `app.js` の設定を変更しましょう。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, forgot this again! 🤦🏻‍♂️. I wonder if we can write a linter or something so that I don't forget this next time

docs/_deployments/ja_aws-lambda.md Outdated
});
```

次、Lambda 関数のイベントに応答するよう、Bolt アプリの [`receiver`](https://slack.dev/bolt-js/ja-jp/concepts#receiver) をカスタマイズします。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
次、Lambda 関数のイベントに応答するよう、Bolt アプリの [`receiver`](https://slack.dev/bolt-js/ja-jp/concepts#receiver) をカスタマイズします。
次に Lambda 関数のイベントに応答するよう、Bolt アプリの [`receiver`](https://slack.dev/bolt-js/ja-jp/concepts#receiver) をカスタマイズします。

docs/_deployments/ja_aws-lambda.md Outdated Show resolved Hide resolved
@seratch seratch added this to the 3.8.0 milestone Oct 18, 2021
@seratch seratch added the docs M-T: Documentation work only label Oct 18, 2021
@wongjas wongjas marked this pull request as ready for review October 18, 2021 05:37
seratch
seratch approved these changes Oct 18, 2021
View reviewed changes
docs/_deployments/ja_aws-lambda.md Outdated Show resolved Hide resolved
@seratch seratch merged commit 02ca6e1 into slackapi:main Oct 18, 2021
@wongjas wongjas deleted the jwong_jp_update_aws_deploy_docs branch October 18, 2021 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seratch seratch seratch approved these changes

Assignees

@wongjas wongjas

Labels
docs M-T: Documentation work only
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.

Apply #1066 changes to AWS Lambda deployment guide in Japanese
2 participants
@wongjas @seratch