Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation about state verification option #1168

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

stophecom
Copy link
Contributor

@stophecom stophecom commented Oct 18, 2021

Summary

This PR fixes the documentation about the usage of the stateVerification option.
On a side note. This probably should be fixed here https://slack.dev/bolt-js/concepts as well.

Requirements (place an x in each [ ])

@CLAassistant
Copy link

CLAassistant commented Oct 18, 2021

CLA assistant check
All committers have signed the CLA.

@srajiang srajiang self-requested a review October 18, 2021 16:24
@srajiang srajiang added the docs M-T: Documentation work only label Oct 18, 2021
@srajiang srajiang added this to the 3.8.0 milestone Oct 18, 2021
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #1168 (4df6cc4) into main (02ca6e1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1168   +/-   ##
=======================================
  Coverage   71.71%   71.71%           
=======================================
  Files          15       15           
  Lines        1354     1354           
  Branches      402      402           
=======================================
  Hits          971      971           
  Misses        312      312           
  Partials       71       71           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02ca6e1...4df6cc4. Read the comment docs.

Copy link
Member

@srajiang srajiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for your contribution @stophecom ! 🙌
With this merged, the page you linked in the PR description should be updated.

@srajiang srajiang merged commit b3f579e into slackapi:main Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants