fail early for unknown action constraints #167
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If you were to mistakenly use the wrong property name on action constraints to match an action listener, you'd end up running the listener for potentially every action. Here is an example:
In this case,
actionId
is not valid, andlistener
would be called for every action. This could have catastrophic results for an app in production.Instead, it would be better if the listener was never called. We can accomplish this by returning before adding the listener to the processing pipeline, and that's what this PR does. Also, it prints an informative error message to the developer.
Requirements (place an
x
in each[ ]
)