-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add line numbers to docs #1797
Add line numbers to docs #1797
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1797 +/- ##
=======================================
Coverage 82.27% 82.27%
=======================================
Files 18 18
Lines 1523 1523
Branches 441 441
=======================================
Hits 1253 1253
Misses 172 172
Partials 98 98 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the look of it, but how does it behave with regard to copy/pasting? Are the numbers carried over? If so, that'd be a no-go for me. I'd also raise this in channel just to ensure there are no unintended consequences as a result.
Barring those two things, LGTM!
The numbers do not carry over 💯 Copied content // Handle a view_submission request
app.view('view_b', async ({ ack, body, view, client, logger }) => {
// Acknowledge the view_submission request
await ack();
// Do whatever you want with the input data - here we're saving it to a DB then sending the user a verification of their submission
// Assume there's an input block with `block_1` as the block_id and `input_a`
const val = view['state']['values']['block_1']['input_a'];
const user = body['user']['id'];
// Message to send user
let msg = '';
// Save to DB
const results = await db.set(user.input, val);
if (results) {
// DB save was successful
msg = 'Your submission was successful';
} else {
msg = 'There was an er |
@misscoded from my post in channel seems like we have the 👍 for this PR |
Summary
This PR introduces line numbers in code block (this is present in the bolt-python docs)
BEFORE
![Screenshot 2023-04-04 at 3 19 01 PM](https://user-images.githubusercontent.com/25348381/229898073-c63797e7-30e6-4a2f-8ed7-d0d259d2f511.png)
AFTER
![Screenshot 2023-04-04 at 3 20 35 PM](https://user-images.githubusercontent.com/25348381/229898128-2af07612-171a-416c-a8e5-a5f3e7f72114.png)
I like the line numbers, let me know what you think, this PR is subjective
Also adds a markdown linter config file
Requirements