Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @slack/types version to ^2.8.0 #1838

Merged
merged 2 commits into from
May 18, 2023
Merged

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented May 15, 2023

Summary

This PR bumps the version of @slack/types to ^2.8.0 – the current version.

Notes

This bump was done to fix the following build error, however I now cannot replicate this with @slack/types@2.7.0 so I am unsure of what actually caused this... However, this upgrade seems appropriate regardless 😃

src/App.ts:1554:11 - error TS2322: Type 'RespondArguments | { text: string; }' is not assignable to type 'RespondArguments'.
  Type '{ text: string; }' is not assignable to type 'RespondArguments'.
    Property 'metadata' is missing in type '{ text: string; }' but required in type 'Pick<ChatPostMessageArguments, "metadata" | "mrkdwn" | "token" | "thread_ts" | "as_user" | "attachments" | "blocks" | "link_names
" | "parse" | "icon_emoji" | ... 4 more ... | "unfurl_media">'.

1554     const normalizedArgs: RespondArguments = typeof message === 'string' ? { text: message } : message;
               ~~~~~~~~~~~~~~


Found 1 error in src/App.ts:1554

Requirements

@zimeg zimeg added semver:patch dependencies Pull requests that update a dependency file labels May 15, 2023
@zimeg zimeg added this to the 3.13.2 milestone May 15, 2023
@zimeg zimeg self-assigned this May 15, 2023
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #1838 (0dfcc17) into main (ba5e2b8) will not change coverage.
The diff coverage is n/a.

❗ Current head 0dfcc17 differs from pull request most recent head 4b58356. Consider uploading reports for the commit 4b58356 to get more accurate results

@@           Coverage Diff           @@
##             main    #1838   +/-   ##
=======================================
  Coverage   82.15%   82.15%           
=======================================
  Files          18       18           
  Lines        1519     1519           
  Branches      435      435           
=======================================
  Hits         1248     1248           
  Misses        175      175           
  Partials       96       96           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zimeg zimeg merged commit 312ad17 into slackapi:main May 18, 2023
@zimeg zimeg deleted the bump-slack-types branch May 18, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file semver:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants