Fix conversation context (and add tests) #187
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change fixes an issue where events that did not have a conversation context would get "stuck" instead of flowing through the middleware and listeners.
But more significantly, this change provides an implementation of unit testing middleware. This pattern have be used to test other middleware as well. This involved pulling common test helpers out of the
*.spec.ts
files, and placing them intotest-helpers.ts
.Fixes #185
Requirements (place an
x
in each[ ]
)