Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several spelling errors on docs #188

Merged
merged 1 commit into from
May 13, 2019

Conversation

seratch
Copy link
Member

@seratch seratch commented May 12, 2019

Summary

This pull request just fixes several spelling errors on docs. I noticed them thanks to my editor's suggestions.

Requirements (place an x in each [ ])

@@ -443,7 +443,7 @@ <h4 class="section-head">Using respond()</h4>
<h3 id="acknowledge">Acknowledging requests</h3>

<div class="section-content">
<p>Actions, commands, and options requests must <strong>always</strong> be acknowledged using the <code class="highlighter-rouge">ack()</code> function. This lets Slack know that the request was received and updates the Slack user interface accordingly. Depending on the type of reuqest, your acknowledgement may be different. For example, when responding to a dialog submission you will call <code class="highlighter-rouge">ack()</code> with validation errors if the submission contains errors, or with no parameters if the submission is valid.</p>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub UI seems to fail highlighting it. Replaced reuqest with request.

@codecov
Copy link

codecov bot commented May 12, 2019

Codecov Report

Merging #188 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #188   +/-   ##
=======================================
  Coverage   54.42%   54.42%           
=======================================
  Files           7        7           
  Lines         441      441           
  Branches      120      120           
=======================================
  Hits          240      240           
  Misses        193      193           
  Partials        8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dc7080...08f1d2e. Read the comment docs.

Copy link
Contributor

@colmdoyle colmdoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching those! 😁

@colmdoyle colmdoyle merged commit 3080b5f into slackapi:master May 13, 2019
@seratch seratch deleted the spelling-errors branch June 20, 2020 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants