Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add typings for timepicker #1928

Merged
merged 1 commit into from
Aug 20, 2023
Merged

Conversation

YussufElarif
Copy link
Contributor

@YussufElarif YussufElarif commented Aug 19, 2023

Summary

The goal of this PR is to add typings for the timepicker element. Thank you 😄

Requirements

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @YussufElarif to sign the Salesforce Inc. Contributor License Agreement.

@seratch seratch added this to the 3.14.0 milestone Aug 20, 2023
@seratch seratch added enhancement M-T: A feature request for new functionality TypeScript-specific labels Aug 20, 2023
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Merging #1928 (3cfe499) into main (6d23725) will not change coverage.
The diff coverage is n/a.

❗ Current head 3cfe499 differs from pull request most recent head 330b4fc. Consider uploading reports for the commit 330b4fc to get more accurate results

@@           Coverage Diff           @@
##             main    #1928   +/-   ##
=======================================
  Coverage   82.18%   82.18%           
=======================================
  Files          18       18           
  Lines        1521     1521           
  Branches      436      436           
=======================================
  Hits         1250     1250           
  Misses        175      175           
  Partials       96       96           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:signed enhancement M-T: A feature request for new functionality TypeScript-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants