-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow a custom SocketModeReceiver
to be used with Socket Mode
#1972
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1972 +/- ##
=======================================
Coverage 82.21% 82.21%
=======================================
Files 18 18
Lines 1524 1524
Branches 438 438
=======================================
Hits 1253 1253
Misses 175 175
Partials 96 96
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Was this in response to a particular issue?
Summary
This PR allows a custom
SocketModeReceiver
to be used with Socket Mode when initializing an app.Reviewers
These changes can be verified with the following snippets:
Socket Mode receiver
This should now work fine! The custom route at
http://localhost:3000/health
and the message response should both respond with something expected.Express receiver
This will still error with an
AppInitializationError
trying to run the app.Requirements