-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update acknowledging_requests.md #2086
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2086 +/- ##
=======================================
Coverage 81.97% 81.97%
=======================================
Files 18 18
Lines 1531 1531
Branches 440 440
=======================================
Hits 1255 1255
Misses 178 178
Partials 98 98 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate the change greatly! Regex is always fun to mess with 🤪
Left a small change to help us catch more of those TLDs with a different syntax - emails ending in .coffee
or .codes
will no longer be missed ☕
Co-authored-by: Ethan Zimbelman <ethan.zimbelman@me.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Thanks for finding this fix! Ready to merge whenever IMO but left one optional suggestion on expanding the regex. I can see good argument for not including it ("we only want plain emails") so feel free to ignore it!
Summary
Update regex based on developer feedback from X (formerly Twitter).
Links to feedback:
https://twitter.com/otrejni/status/1625787621057101825
https://twitter.com/otrejni/status/1625790926042943489
Requirements (place an
x
in each[ ]
)