Add a type predicate for CodedError
#2110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… appeared in `main` somehow.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2110 +/- ##
==========================================
+ Coverage 81.97% 81.99% +0.02%
==========================================
Files 18 18
Lines 1531 1533 +2
Branches 440 440
==========================================
+ Hits 1255 1257 +2
Misses 178 178
Partials 98 98 ☔ View full report in Codecov by Sentry. |
This was referenced Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...fixing a typescript error that appeared in
mainsomehow.Not sure how this started happening... the last commit to
main2 weeks ago passed CI just fine. However, todaymainstarted failing the CI.In any case, the issue seems to be in narrowing the type of errors returned in the error handler. I added a new type predicate to help with the narrowing.