Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ButtonAction value field not required #2134

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

srajiang
Copy link
Member

Summary

Fix #2133

Corrects typing to align with documentation and actual API behavior.

Requirements (place an x in each [ ])

@srajiang srajiang added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch TypeScript-specific labels Jun 12, 2024
@srajiang srajiang added this to the 3.19.0 milestone Jun 12, 2024
@srajiang srajiang self-assigned this Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.03%. Comparing base (c2e26c4) to head (938d546).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2134   +/-   ##
=======================================
  Coverage   82.03%   82.03%           
=======================================
  Files          18       18           
  Lines        1536     1536           
  Branches      442      442           
=======================================
  Hits         1260     1260           
  Misses        178      178           
  Partials       98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome saucesome on such a quick fix! 🚀 Thanks for linking the docs too - LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch TypeScript-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The 'value' property on ButtonAction is incorrectly typed
2 participants