Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link in "external select" section #2169

Merged
merged 5 commits into from
Jul 24, 2024
Merged

Conversation

ornato-t
Copy link
Contributor

Summary

This PR fixes a broken link in the External Select Options page of the documentation.
Specifically, the link heads to the Block Kit Reference page but incorrectly targets the relevant paragraph using a dash - in its id instead of an underscore _.

Requirements (place an x in each [ ])

@zimeg zimeg added docs M-T: Documentation work only semver:patch labels Jul 24, 2024
@zimeg zimeg added this to the 3.20.0 milestone Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.07%. Comparing base (c361502) to head (8bbf73f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2169   +/-   ##
=======================================
  Coverage   82.07%   82.07%           
=======================================
  Files          18       18           
  Lines        1545     1545           
  Branches      443      443           
=======================================
  Hits         1268     1268           
  Misses        179      179           
  Partials       98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ornato-t 👋 Thanks for sending this in! It all looks good to me!

I did go ahead and update the same link on the Japanese version of this page as well as the redirected link to legacy dialog documentation to remove possible confusion around this too.

Really appreciate ya taking the time to make this fix 🙏 📚

@zimeg zimeg merged commit d6036b0 into slackapi:main Jul 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:signed docs M-T: Documentation work only semver:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants