Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs - fixes README image link #2180

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

lukegalbraithrussell
Copy link
Contributor

@lukegalbraithrussell lukegalbraithrussell commented Aug 1, 2024

Summary

The Repo README uses a /docs image. This updates the path that changed when the site switched to using Docusaurus.

It uses the full link for display in npm. The GitHub README wasn't reading in the .svg size adjustment when given the full link via markdown, so used HTML and sized it manually. (Same size as in .svg file).

Tested it work by previewing the README with the changes in browser

Requirements

@lukegalbraithrussell lukegalbraithrussell marked this pull request as ready for review August 1, 2024 18:14
@lukegalbraithrussell lukegalbraithrussell added the docs M-T: Documentation work only label Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.07%. Comparing base (dccafb2) to head (ac1d36e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2180   +/-   ##
=======================================
  Coverage   82.07%   82.07%           
=======================================
  Files          18       18           
  Lines        1545     1545           
  Branches      443      443           
=======================================
  Hits         1268     1268           
  Misses        179      179           
  Partials       98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukegalbraithrussell lukegalbraithrussell merged commit 945e9f0 into main Aug 1, 2024
9 checks passed
@lukegalbraithrussell lukegalbraithrussell deleted the luke-readme-broken-img-link branch August 1, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants