Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added complete, fail and inputs parameters on SlackActionMiddlewareArgs #2189

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Aug 8, 2024

So that action handlers have access to complete, fail and inputs parameters.

Tested this branch w/ bolt-ts-starter-template linked together, and could get the sample action in the starter template to have IDE autocomplete support for complete, fail and inputs.

@filmaj filmaj requested a review from misscoded August 8, 2024 19:32
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.87%. Comparing base (f7966e7) to head (519da97).

Additional details and impacted files
@@                Coverage Diff                @@
##           pre-stable-fixes    #2189   +/-   ##
=================================================
  Coverage             80.87%   80.87%           
=================================================
  Files                    19       19           
  Lines                  1637     1637           
  Branches                461      461           
=================================================
  Hits                   1324     1324           
  Misses                  205      205           
  Partials                108      108           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@misscoded misscoded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On mobile, so cannot test first hand, but so long as we've verified it works in a TS project, LGTM! :shipit:

@filmaj filmaj merged commit d390d8f into pre-stable-fixes Aug 8, 2024
9 checks passed
@filmaj filmaj deleted the action-step-callbacks branch August 8, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants