Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title to setSuggestedPrompts utility #2308

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Conversation

misscoded
Copy link
Contributor

Summary

Updates setSuggestedPrompts to include an optional title property:

setSuggestedPrompts({ title: 'Here are some suggested options:', prompts });
Screenshot 2024-10-28 at 5 06 02 PM

Requirements (place an x in each [ ])

@misscoded misscoded added the enhancement M-T: A feature request for new functionality label Oct 29, 2024
@misscoded misscoded requested review from seratch and filmaj October 29, 2024 00:10
@seratch seratch added this to the 4.0.2 milestone Oct 29, 2024
src/Assistant.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of suggestions but LGTM overall

src/Assistant.ts Show resolved Hide resolved
src/Assistant.ts Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.49%. Comparing base (d3fe549) to head (cf83fd5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2308   +/-   ##
=======================================
  Coverage   92.48%   92.49%           
=======================================
  Files          36       36           
  Lines        7466     7472    +6     
  Branches      651      651           
=======================================
+ Hits         6905     6911    +6     
  Misses        553      553           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -57,23 +57,20 @@ const config = {
redirects: [
{
to: '/getting-started',
from: ['/tutorial/getting-started','/tutorial/getting-started-http'],
from: ['/tutorial/getting-started', '/tutorial/getting-started-http'],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukegalbraithrussell 👋🏼 When you make docs changes, make sure to run the linter so these aren't picked up by subsequent PRs. It'll help us keep the changes for each PR scoped to what they're actually about.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm i think maybe i ran the wrong linter because it changed all of this just in my last PR. (Most notably in that sidebar.js file -- I would never manually use double quotations willingly so i remember it changing them all). I'll figure out what happened

@misscoded misscoded merged commit 4b6b25f into main Oct 29, 2024
20 checks passed
@misscoded misscoded deleted the update-set-suggested-prompts branch October 29, 2024 19:56
@filmaj filmaj modified the milestones: 4.0.2, 4.1 Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants