Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: find the biome config schema from the installed path #2363

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented Dec 11, 2024

Summary

This PR updates the $schema of biome.json to use the relative path to the installed JSON schema file, as recommended in https://biomejs.dev/reference/configuration/#schema

Fixes an issue where an updated version of biome might add or remove configurations not existing for version 1.8.3, which would invalidate this JSON schema! 😳

Requirements

@zimeg zimeg added this to the 4.1.2 milestone Dec 11, 2024
@zimeg zimeg requested review from seratch and a team December 11, 2024 01:03
@zimeg zimeg self-assigned this Dec 11, 2024
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makese sense; LGTM

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.59%. Comparing base (37ae33e) to head (aeb2051).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2363   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files          36       36           
  Lines        7472     7472           
  Branches      653      653           
=======================================
  Hits         6919     6919           
  Misses        545      545           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zimeg
Copy link
Member Author

zimeg commented Dec 11, 2024

@seratch thanks for the fast review! 🙏 ✨

I noticed this version seemed unexpected in adjacent changes, and suspect similar patterns might exist elsewhere 🔍 I'll keep an eye out for matching changes in other repos but will merge this now!

@zimeg zimeg merged commit 73bd49e into main Dec 11, 2024
18 checks passed
@zimeg zimeg deleted the zimeg-build-biome-relative-schema branch December 11, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants