Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tab, view to AppHomeOpenedEvent #292

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

seratch
Copy link
Member

@seratch seratch commented Oct 23, 2019

Summary

Although the API documentation team is still working on the updates on the page (the updates will come very soon), app_home_opened event has two more fields - tab and view as announced at the Spec conference yesterday (Refer to https://api.slack.com/surfaces/tabs for details of App Home).

This pull request adds those to the type definition to better support it in TypeScript.

Requirements (place an x in each [ ])

@seratch seratch requested a review from aoberoi October 23, 2019 19:12
@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #292 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #292   +/-   ##
=======================================
  Coverage   73.71%   73.71%           
=======================================
  Files           7        7           
  Lines         506      506           
  Branches      145      145           
=======================================
  Hits          373      373           
  Misses        101      101           
  Partials       32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db5e27e...64974bd. Read the comment docs.

@aoberoi aoberoi merged commit 02e38c0 into slackapi:master Oct 23, 2019
@seratch seratch deleted the app_home_opened-event branch October 23, 2019 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants