Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove users info api call #347

Merged
merged 6 commits into from
Dec 17, 2019
Merged

Remove users info api call #347

merged 6 commits into from
Dec 17, 2019

Conversation

pichsenmeister
Copy link
Member

Summary

This pull request fixes #346 by removing users.info call from SingleTeamAuthorization, since this information is now part of the auth.test response payload.

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented Dec 16, 2019

Codecov Report

Merging #347 into master will decrease coverage by 0.35%.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #347      +/-   ##
========================================
- Coverage   73.35%    73%   -0.36%     
========================================
  Files           7      7              
  Lines         503    500       -3     
  Branches      146    146              
========================================
- Hits          369    365       -4     
- Misses        102    103       +1     
  Partials       32     32
Impacted Files Coverage Δ
src/ExpressReceiver.ts 50.96% <ø> (ø) ⬆️
src/App.ts 78.23% <50%> (-0.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4519546...fe27647. Read the comment docs.

@pichsenmeister pichsenmeister force-pushed the remove_users_info_api_call branch from 3fe57bb to a379afc Compare December 16, 2019 23:23
src/App.ts Outdated Show resolved Hide resolved
src/App.ts Outdated Show resolved Hide resolved
src/App.ts Outdated Show resolved Hide resolved
src/App.ts Outdated Show resolved Hide resolved
@aoberoi aoberoi merged commit d59319c into master Dec 17, 2019
@aoberoi aoberoi deleted the remove_users_info_api_call branch December 17, 2019 15:58
@aoberoi
Copy link
Contributor

aoberoi commented Dec 17, 2019

(used admin override to merge even though codecov wasn't satisfied)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove users.info call from SingleTeamAuthorization
4 participants