Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #377 ExpressReceiver's RespondFn implementation doesn't accept a string #379

Merged
merged 2 commits into from
Jan 22, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented Jan 21, 2020

Summary

This pull request fixes #377 by updating the response function generation in ExpressReceiver. I wanted to write some tests for it but it's still not so easy to have uni tests for the internals of the requestHandler method. So, I just cut and pasted the same logic to a test suite this time.

Requirements (place an x in each [ ])

@seratch seratch added the bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented label Jan 21, 2020
@seratch seratch requested review from stevengill and aoberoi January 21, 2020 18:48
@seratch seratch self-assigned this Jan 21, 2020
@codecov
Copy link

codecov bot commented Jan 21, 2020

Codecov Report

Merging #379 into master will increase coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #379      +/-   ##
==========================================
+ Coverage   82.86%   83.13%   +0.26%     
==========================================
  Files           7        7              
  Lines         502      510       +8     
  Branches      147      148       +1     
==========================================
+ Hits          416      424       +8     
  Misses         57       57              
  Partials       29       29
Impacted Files Coverage Δ
src/ExpressReceiver.ts 70.17% <100%> (+2.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 279b97b...d83d279. Read the comment docs.

@seratch seratch merged commit 7c89750 into slackapi:master Jan 22, 2020
@seratch seratch deleted the issue-377 branch January 22, 2020 00:17
@seratch seratch mentioned this pull request Apr 22, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExpressReceiver's RespondFn implementation doesn't accept a string
2 participants