Fix #382 Missing invite_requested event type #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #387 +/- ##
==========================================
+ Coverage 83.13% 83.68% +0.54%
==========================================
Files 7 7
Lines 510 527 +17
Branches 148 151 +3
==========================================
+ Hits 424 441 +17
Misses 57 57
Partials 29 29
Continue to review full report at Codecov.
|
aoberoi
suggested changes
Feb 3, 2020
src/types/events/base-events.ts
Outdated
| date_created: number; | ||
| requester_ids: string[]; | ||
| channel_ids: string[]; | ||
| invite_type: string; |
There was a problem hiding this comment.
there are three specific strings the invite_type value can be: restricted, ultra_restricted, or full_member. source: https://api.slack.com/admins/inviting#events
There was a problem hiding this comment.
@aoberoi Good catch! I just modified it to be more specific. 👍
aoberoi
approved these changes
Feb 3, 2020
stevengill
approved these changes
Feb 3, 2020
|
This one is also the same to #359 (comment) |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes #382 by adding a new event type to base-events.ts
https://api.slack.com/events/invite_requested
@aoberoi @stevengill @shaydewael
If you're aware of some fields that need to be optional, please point them out. 🙏
Requirements (place an
xin each[ ])