Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese version of v2 migration & TS guide #457

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented Mar 31, 2020

Summary

This pull request adds Japanese version updates for the v2 migration guide and newly added TypeScript page. The following are the original pages.

Requirements (place an x in each [ ])

@seratch seratch added the docs M-T: Documentation work only label Mar 31, 2020
@seratch seratch self-assigned this Mar 31, 2020
@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #457 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #457   +/-   ##
=======================================
  Coverage   84.72%   84.72%           
=======================================
  Files           7        7           
  Lines         550      550           
  Branches      163      163           
=======================================
  Hits          466      466           
  Misses         57       57           
  Partials       27       27           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a5b905...3605872. Read the comment docs.

@seratch
Copy link
Member Author

seratch commented Mar 31, 2020

@shanreng Thanks for your review!

@seratch seratch merged commit d4a3f2a into slackapi:master Mar 31, 2020
@seratch seratch deleted the v2-japanese-docs branch March 31, 2020 07:09
Copy link

@MarkHash MarkHash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion for # TypeScript での利用ガイド part

  • The sentence around "あなたも TypeScript" is a bit odd
    My suggestion:

TypeScript を使って開発している場合には、このドキュメントがスムーズなコードの記述、エラーの早期発見、簡単なリファクタリングなどに役立つでしょう。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants