Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add middleware matching app_mention events' text #499

Merged
merged 2 commits into from
May 27, 2020

Conversation

hashedhyphen
Copy link
Contributor

Summary

Issue: #489

This PR is for a new middleware to filter app_mention-event texts, based on feedback in #489.

cc: @seratch @stevengill

Requirements (place an x in each [ ])

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the naming of the new private method

src/middleware/builtin.ts Outdated Show resolved Hide resolved
@seratch seratch added the enhancement M-T: A feature request for new functionality label May 18, 2020
@seratch seratch changed the title Add middleware to filter app_mention-event texts Add middleware matching app_mention events' text May 18, 2020
src/middleware/builtin.ts Outdated Show resolved Hide resolved
@hashedhyphen hashedhyphen force-pushed the feat/match-app-mention branch from ae0f4ff to 7defbd2 Compare May 23, 2020 14:28
@aoberoi
Copy link
Contributor

aoberoi commented May 27, 2020

This looks great @hashedhyphen! Thanks for following through with this from reporting the problem, to conceptualizing a solution, implementing it, testing it, and revising it based on feedback 👏

@seratch seratch merged commit ca63084 into slackapi:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants