Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document: Add text arg when having blocks in say() calls #535

Merged
merged 2 commits into from
Jul 7, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented Jul 2, 2020

Summary

This pull request improves the code snippets in the "Getting Started" document by adding text argument when using blocks for composing a message. This enables the code to be more optimal in terms of usability plus compatible with TypeScript.

For context: #532 (comment)

Requirements (place an x in each [ ])

@seratch seratch added the docs M-T: Documentation work only label Jul 2, 2020
@seratch seratch requested a review from stevengill July 2, 2020 23:55
@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #535 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #535   +/-   ##
=======================================
  Coverage   83.13%   83.13%           
=======================================
  Files           7        7           
  Lines         593      593           
  Branches      184      184           
=======================================
  Hits          493      493           
  Misses         68       68           
  Partials       32       32           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d98952...ad8b10a. Read the comment docs.

@aoberoi
Copy link
Contributor

aoberoi commented Jul 6, 2020

great idea!

@seratch seratch merged commit 0b37456 into slackapi:master Jul 7, 2020
@seratch seratch deleted the docs-code-snippet-fix branch July 7, 2020 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants