Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize fetchInstallation to use installQuery as argument #777

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

misscoded
Copy link
Contributor

Summary

Currently, fetchInstallation uses InstallQuery as an argument, which suggests a class is being passed.

This PR aligns all instances to use installQuery instead of InstallQuery, aligning with corresponding changes to the Node SDK.

Requirements (place an x in each [ ])

@misscoded misscoded added the docs M-T: Documentation work only label Feb 3, 2021
@misscoded misscoded self-assigned this Feb 3, 2021
@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #777 (7615fe9) into main (3a68fd7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #777   +/-   ##
=======================================
  Coverage   65.24%   65.24%           
=======================================
  Files          11       11           
  Lines        1082     1082           
  Branches      320      320           
=======================================
  Hits          706      706           
  Misses        317      317           
  Partials       59       59           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a68fd7...69931bd. Read the comment docs.

@seratch
Copy link
Member

seratch commented Feb 3, 2021

Thanks!

@stevengill stevengill merged commit adff9a3 into slackapi:main Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants