Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix events documentation code sample to use event.user #790

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

mwbrooks
Copy link
Member

Summary

The event documentation's code sample references event.user.id which is undefined. The user ID is available with event.user.

Requirements (place an x in each [ ])

@mwbrooks mwbrooks added the docs M-T: Documentation work only label Feb 11, 2021
@mwbrooks mwbrooks self-assigned this Feb 11, 2021
@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #790 (0841938) into main (64eb7ed) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #790   +/-   ##
=======================================
  Coverage   65.24%   65.24%           
=======================================
  Files          11       11           
  Lines        1082     1082           
  Branches      320      320           
=======================================
  Hits          706      706           
  Misses        317      317           
  Partials       59       59           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64eb7ed...1166bd1. Read the comment docs.

@seratch
Copy link
Member

seratch commented Feb 11, 2021

@mwbrooks Good catch - thanks 👍

@seratch seratch merged commit e554d27 into slackapi:main Feb 11, 2021
@mwbrooks mwbrooks deleted the docs-events-user-id branch February 11, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants