Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incomplete logged sentence in SocketModeReciever #807

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Fix incomplete logged sentence in SocketModeReciever #807

merged 1 commit into from
Feb 22, 2021

Conversation

khrj
Copy link
Contributor

@khrj khrj commented Feb 20, 2021

Summary

-this.logger.error(`Tried to reach ${req.url} which isn't a`);	
+this.logger.error(`Tried to reach ${req.url} which isn't a valid route.`);

Requirements (place an x in each [ ])

@gitwave gitwave bot added the untriaged label Feb 20, 2021
@codecov
Copy link

codecov bot commented Feb 20, 2021

Codecov Report

Merging #807 (d3b610c) into main (ea5adc9) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #807   +/-   ##
=======================================
  Coverage   65.47%   65.47%           
=======================================
  Files          11       11           
  Lines        1089     1089           
  Branches      323      323           
=======================================
  Hits          713      713           
  Misses        317      317           
  Partials       59       59           
Impacted Files Coverage Δ
src/receivers/SocketModeReceiver.ts 9.80% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea5adc9...4e247ca. Read the comment docs.

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented and removed untriaged labels Feb 20, 2021
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the change looks good to me. Other maintainers will check this early next week.

@stevengill stevengill merged commit f722fe8 into slackapi:main Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants