Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commonize the HTML rendering for OAuth install path #810

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented Feb 24, 2021

Summary

This pull request improves the internals of built-in receivers by commonizing duplicated code across the implementations.

Requirements (place an x in each [ ])

@seratch seratch added the enhancement M-T: A feature request for new functionality label Feb 24, 2021
@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #810 (9cacbe8) into main (f722fe8) will increase coverage by 0.12%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #810      +/-   ##
==========================================
+ Coverage   65.47%   65.59%   +0.12%     
==========================================
  Files          11       12       +1     
  Lines        1089     1093       +4     
  Branches      323      323              
==========================================
+ Hits          713      717       +4     
  Misses        317      317              
  Partials       59       59              
Impacted Files Coverage Δ
src/receivers/ExpressReceiver.ts 66.87% <50.00%> (+0.20%) ⬆️
src/receivers/HTTPReceiver.ts 17.15% <50.00%> (+0.59%) ⬆️
src/receivers/SocketModeReceiver.ts 11.53% <50.00%> (+1.73%) ⬆️
src/receivers/render-html-for-install-path.ts 50.00% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f722fe8...5517060. Read the comment docs.

@stevengill stevengill merged commit 3b7ae8a into slackapi:main Feb 24, 2021
@seratch seratch deleted the html-rendering branch February 25, 2021 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality semver:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants