Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arguments type for App.start() #823

Merged
merged 2 commits into from
Mar 8, 2021
Merged

Fix arguments type for App.start() #823

merged 2 commits into from
Mar 8, 2021

Conversation

khrj
Copy link
Contributor

@khrj khrj commented Mar 6, 2021

Summary

app.start() doesn't need any arguments if the socket mode receiver (socketMode: true) is used, so the type needs to be changed to support that

Requirements

Merges khrj/slack-bolt#2

@seratch
Copy link
Member

seratch commented Mar 7, 2021

@KhushrajRathod Thanks for taking the time to submit this PR! The CI builds are failing as below. Can you run npx prettier -w src/ && npm test and push the changes?

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @slack/bolt@3.2.0 lint: `prettier 'src/**/*.ts' --check && eslint --ext .ts src`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @slack/bolt@3.2.0 lint script.

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented TypeScript-specific and removed untriaged labels Mar 7, 2021
@seratch seratch self-requested a review March 7, 2021 01:02
@khrj
Copy link
Contributor Author

khrj commented Mar 7, 2021

@seratch Done

@codecov
Copy link

codecov bot commented Mar 7, 2021

Codecov Report

Merging #823 (744bd8b) into main (7d8654c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #823   +/-   ##
=======================================
  Coverage   66.04%   66.04%           
=======================================
  Files          13       13           
  Lines        1172     1172           
  Branches      342      342           
=======================================
  Hits          774      774           
  Misses        333      333           
  Partials       65       65           
Impacted Files Coverage Δ
src/App.ts 83.63% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d8654c...ca7b4a6. Read the comment docs.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other maintainers will check this early next week (North America time)

@stevengill stevengill merged commit c1e2e5b into slackapi:main Mar 8, 2021
@stevengill
Copy link
Member

Thanks @KhushrajRathod

@khrj
Copy link
Contributor Author

khrj commented Mar 8, 2021

Np!

@khrj khrj deleted the patch-1 branch March 8, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:minor TypeScript-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants