-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix arguments type for App.start() #823
Conversation
@KhushrajRathod Thanks for taking the time to submit this PR! The CI builds are failing as below. Can you run
|
@seratch Done |
Codecov Report
@@ Coverage Diff @@
## main #823 +/- ##
=======================================
Coverage 66.04% 66.04%
=======================================
Files 13 13
Lines 1172 1172
Branches 342 342
=======================================
Hits 774 774
Misses 333 333
Partials 65 65
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other maintainers will check this early next week (North America time)
Thanks @KhushrajRathod |
Np! |
Summary
app.start()
doesn't need any arguments if the socket mode receiver (socketMode: true) is used, so the type needs to be changed to support thatRequirements
Merges khrj/slack-bolt#2