Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #629 confusing debug log by ConversationStore #827

Merged

Conversation

seratch
Copy link
Member

@seratch seratch commented Mar 10, 2021

Summary

This pull request resolves #629 by getting rid of confusing and irrelevant debug logs for most developers.

Requirements (place an x in each [ ])

@seratch seratch added the enhancement M-T: A feature request for new functionality label Mar 10, 2021
@seratch seratch requested review from mwbrooks and stevengill March 10, 2021 05:26
@seratch seratch self-assigned this Mar 10, 2021
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #827 (3fdf04a) into main (257dd6d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #827      +/-   ##
==========================================
+ Coverage   66.04%   66.06%   +0.02%     
==========================================
  Files          13       13              
  Lines        1172     1173       +1     
  Branches      342      343       +1     
==========================================
+ Hits          774      775       +1     
  Misses        333      333              
  Partials       65       65              
Impacted Files Coverage Δ
src/conversation-store.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 257dd6d...4e9a676. Read the comment docs.

@misscoded misscoded merged commit b8bc037 into slackapi:main Mar 10, 2021
@seratch seratch deleted the issue-629-remove-confusing-debug-logs branch March 10, 2021 21:55
seratch added a commit that referenced this pull request Mar 10, 2021
@seratch seratch added this to the 3.4.0 milestone Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing debug logs by ConversationStore
3 participants