Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trigger_id to ViewSubmitAction interface #828

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

misscoded
Copy link
Contributor

Summary

Adds trigger_id to the ViewSubmitAction interface.

Fixes #572

Requirements (place an x in each [ ])

Sorry, something went wrong.

@misscoded misscoded added enhancement M-T: A feature request for new functionality semver:patch TypeScript-specific labels Mar 11, 2021
@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #828 (bb34be2) into main (7f5725a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #828   +/-   ##
=======================================
  Coverage   65.89%   65.89%           
=======================================
  Files          13       13           
  Lines        1173     1173           
  Branches      343      343           
=======================================
  Hits          773      773           
  Misses        334      334           
  Partials       66       66           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f5725a...bb34be2. Read the comment docs.

@seratch
Copy link
Member

seratch commented Mar 11, 2021

Although we don't highly recommend using the trigger_id (reasons: opening one more modal using views.open API does not properly work; you can use response_action in an HTTP response for update/push modals), the value actually exists. So, this change looks good to me.

Copy link
Member

@stevengill stevengill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!!

@misscoded misscoded merged commit 9e783e4 into slackapi:main Mar 11, 2021
@seratch seratch added this to the 3.4.0 milestone Mar 23, 2021
@SpencerKaiser
Copy link

@seratch

reasons: opening one more modal using views.open API does not properly work; you can use response_action in an HTTP response for update/push modals

Can you explain this a bit more? I just read through the docs again and I see no mention of response_action anywhere... isn't a trigger_id necessary for using views.update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality semver:patch TypeScript-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ViewSubmitAction type missing trigger_id
4 participants