Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #757 Add event type name validation & channel_type filter middleware #857

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented Mar 24, 2021

Summary

This pull request fixes #757 - refer to the issue for details.

Requirements (place an x in each [ ])

@gitwave gitwave bot added the untriaged label Mar 24, 2021
@seratch seratch requested review from stevengill and mwbrooks March 24, 2021 14:39
@seratch seratch self-assigned this Mar 24, 2021
@seratch seratch added enhancement M-T: A feature request for new functionality and removed untriaged labels Mar 24, 2021
@seratch seratch added this to the 3.4.0 milestone Mar 24, 2021
@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #857 (d9b666f) into main (afcd7bd) will increase coverage by 0.17%.
The diff coverage is 88.88%.

❗ Current head d9b666f differs from pull request most recent head 62a14e5. Consider uploading reports for the commit 62a14e5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #857      +/-   ##
==========================================
+ Coverage   65.98%   66.16%   +0.17%     
==========================================
  Files          13       13              
  Lines        1176     1185       +9     
  Branches      344      347       +3     
==========================================
+ Hits          776      784       +8     
  Misses        334      334              
- Partials       66       67       +1     
Impacted Files Coverage Δ
src/App.ts 83.77% <88.88%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afcd7bd...62a14e5. Read the comment docs.

@seratch seratch merged commit 78e605b into slackapi:main Mar 25, 2021
@seratch seratch deleted the issue-757 branch March 25, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality semver:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add event type name validation & channel_type filter middleware
2 participants